Update bazel build #1288
Merged
Update bazel build #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Vertexwahn
force-pushed
the
update-bazel-build
branch
from
d8b89d1
to
57f1c8a
Compare
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Vertexwahn
force-pushed
the
update-bazel-build
branch
from
57f1c8a
to
583e14f
Compare
Signed-off-by: Vertexwahn <julian.amann@tum.de>
Vertexwahn
force-pushed
the
update-bazel-build
branch
from
4b25e6c
to
5c05d1d
Compare
|
Thanks for the contribution. I see a bunch of pushes in a row, so maybe this is work in progress? Can you add a note when this is ready? |
|
Done. |
|
ok :) |
meshula
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only influences the Bazel build experience:
expand_templateinstead of own implementation (has unit tests, etc.)openexrtocom_openexr(usually a naming convention is used that follows the patterndomainextension_organisation_libraryname- e.g.com_google_googletest- maybecom_academy_software_foundation_openexris better?)